linux-kernel - Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Sep 2009 12:19:21 +0200
From:	Mikael Pettersson <mikpe@...uu.se>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [RFC Patch] kbuild: remove -Wdeclaration-after-statement

Amerigo Wang writes:
 > 
 > I got lots of "ISO C90 forbids mixed declarations and code" warnings
 > during compile today's kernel.
 > 
 > I think we can remove the gcc option '-Wdeclaration-after-statement'
 > now, since we already have C99 for 10 years. :)
 > 
 > Signed-off-by: WANG Cong <amwang@...hat.com>
 > Cc: Sam Ravnborg <sam@...nborg.org>
 > 
 > ---
 > diff --git a/Makefile b/Makefile
 > index 433493a..038bda2 100644
 > --- a/Makefile
 > +++ b/Makefile
 > @@ -559,9 +559,6 @@ endif
 >  NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include)
 >  CHECKFLAGS     += $(NOSTDINC_FLAGS)
 >  
 > -# warn about C99 declaration after statement
 > -KBUILD_CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
 > -
 >  # disable pointer signed / unsigned warnings in gcc 4.0
 >  KBUILD_CFLAGS += $(call cc-option,-Wno-pointer-sign,)

This is more a matter of coding-style policy than C technicalities.

I happen to hate declarations at random places in the code, so I'd
prefer the offending code to be fixed instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/