linux-kernel - Re: [origin tree build failure] [PATCH] USB sierra: Fix build if !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Sep 2009 19:39:44 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Greg KH <gregkh@...e.de>, Oliver Neukum <oliver@...kum.org>,
	Elina Pasheva <epasheva@...rrawireless.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [origin tree build failure] [PATCH] USB sierra: Fix build if
	!CONFIG_PM


* Randy Dunlap <randy.dunlap@...cle.com> wrote:

> Ingo Molnar wrote:
> >>       USB: support for autosuspend in sierra while online
> > 
> > FYI, -tip testing found a build failure with the sierra driver on 
> > !CONFIG_PM - fixed via the patch below.
> > 
> > Thanks,
> > 
> > 	Ingo
> > 
> > -------------------->
> > From 26f8ed899041199caa9315e057a28d10f81b5b88 Mon Sep 17 00:00:00 2001
> > From: Ingo Molnar <mingo@...e.hu>
> > Date: Wed, 23 Sep 2009 19:19:47 +0200
> > Subject: [PATCH] USB sierra: Fix build if !CONFIG_PM
> > 
> > This build failure:
> > 
> >   drivers/usb/serial/sierra.c: In function 'sierra_suspend':
> >   drivers/usb/serial/sierra.c:936: error: 'struct usb_device' has no member named 'auto_pm'
> > 
> > Triggers because the ->auto_pm functionality depends on CONFIG_PM.
> > 
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> Ack.
> http://marc.info/?l=linux-usb&m=125305135600816&w=2
> 
> lossy. :(

yeah, indeed.

Btw., i think my patch is a bit better as it also includes 
stop_read_write_urbs() in the #ifdef block - your patch would probably 
trigger a 'defined but not used' compiler warning. (have not checked 
though.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/