linux-kernel - Re: [origin tree boot hang] [PATCH] Revert "early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Sep 2009 16:19:02 -0500
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Len Brown <lenb@...nel.org>, Greg KH <gregkh@...e.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [origin tree boot hang] [PATCH] Revert "early_printk: Allowmorethan
 one early console"

Ingo Molnar wrote:
> * Ingo Molnar <mingo@...e.hu> wrote:
>
>
>   
>> The commit point to which the attached config and bootlog belongs is:
>>
>>   2.6.31-07863-gb64ada6
>>
>> Reverting:
>>
>>   c953094: early_printk: Allow more than one early console
>>
>> solves it.
>>     
>
> btw., the boot options are:
>
> Command line: root=/dev/sda6 earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 debug
> initcall_debug apic=verbose sysrq_always_enabled ignore_loglevel 
> selinux=0 nmi_watchdog=0 panic=1 3
>
>   

AH HA!

earlyprintk=serial,ttyS0,115200

You are invoking the same device twice which is why you are having infinite recursion.  It was not obvious to me why the earlyprintk code would allow "serial" or "ttyS", but perhaps we need to protect for that?

Your boot line should be:

earlyprintk=serial,115200

OR

earlyprintk=ttyS0,115200

The line you had there before would have been the equivalent of doing:

earlyprintk=ttyS0,ttyS0,115200

Given this, do we still need to execute the revert your revert?  Or perhaps do we need to add some protection?

Thanks,
Jason.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/