lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 23 Sep 2009 11:11:15 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Chris Mason <chris.mason@...cle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"Li, Shaohua" <shaohua.li@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"richard@....demon.co.uk" <richard@....demon.co.uk>,
	"jens.axboe@...cle.com" <jens.axboe@...cle.com>
Subject: Re: regression in page writeback

On Wed, Sep 23, 2009 at 10:56:05AM +0800, Andrew Morton wrote:
> On Wed, 23 Sep 2009 10:49:58 +0800 Wu Fengguang <fengguang.wu@...el.com> wrote:
> 
> > > After the sleep we repoll all queues.
> > 
> > I mean, it is not always necessary. Only when _all_ superblocks cannot
> > writeback their inodes (eg. all in congestion), we should wait.
> 
> Well.  The code will still submit MAX_WRITEBACK_PAGES pages to _some_
> queue in that situation.
> 
> But yup, maybe that's a bug!  Sounds easy to fix.  It doesn't justify
> rewriting the whole world and then saying "look, the new code is faster
> than the old code which had a bug which I knew about but didn't fix".

I didn't submit the patches to avoid conflicts with Jens' work.
Sorry for doing that - that's not good attitude towards bug fixes..

Thanks,
Fengguang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ