linux-kernel - Re: [origin tree build failure] [PATCH] thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Sep 2009 17:35:26 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Len Brown <lenb@...nel.org>
Cc:	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-acpi@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [origin tree build failure] [PATCH] thinkpad-acpi: Fix build
	on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL

* Len Brown <lenb@...nel.org> wrote:

> 
> > > >  drivers/platform/x86/thinkpad_acpi.c    |  632 +++++++++++++++++++---------
> > > 
> > > -tip testing found that these changes caused a build failure 
> > > in drivers/platform/x86/thinkpad_acpi.c when 
> > > !CONFIG_THINKPAD_ACPI_HOTKEY_POLL - the fix is attached  below.
> > 
> > Fixed by a different patch, which will hit mainline soon....
> 
> Ingo,
> 2.6.32-rc1 should build fine* -- let me know if it doesn't.
> 
> thanks,
> Len Brown, Intel Open Source Technology Center
> 
> * module this message, which Henruque assures me will go away soon
> drivers/platform/x86/thinkpad_acpi.c:2225: warning: 
> ‘tpacpi_hotkey_driver_mask_set’ defined but not used

well, the warning is fixed properly in my patch, as pointed out in the 
changelog. Have you read that?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/