linux-kernel - Re: [PATCH] tty: fix vt_compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Sep 2009 01:56:15 +0200
From:	Florian Mickler <florian@...kler.org>
To:	Andreas Schwab <schwab@...ux-m68k.org>,
	linux-kernel@...r.kernel.org, Greg KH <gregkh@...e.de>
Subject: Re: [PATCH] tty: fix vt_compat_ioctl

Hi!

On Mon, 28 Sep 2009 21:21:14 +0200
Andreas Schwab <schwab@...ux-m68k.org> wrote:

> Greg KH <gregkh@...e.de> writes:
> 
> > On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote:
> >> Call compat_unimap_ioctl, not do_unimap_ioctl.
> >
> > That's a nice description of what the patch does, but why do we need to
> > do that?
> 
> It's a compat ioctl handler, so lets call the compat ioctl handler.
> 
> Andreas.
> 

Any other reasons? Why not rename the call then? That would be a
functional no-op with the same effect... 


Sincerely,
Florian

p.s. maybe it is obvious if one looks at the code (i didnt), but it
should be described nonetheless in the commit-log!

-- 
A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?  
>> A: Top-posting.  
>>> Q: What is the most annoying thing in e-mail?

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)