linux-kernel - Re: [PATCH] congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Oct 2009 10:10:12 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>
Subject: Re: [PATCH] congestion_wait() don't use WRITE

On Fri, Oct 02 2009, KOSAKI Motohiro wrote:
> 
> commit 8aa7e847d (Fix congestion_wait() sync/async vs read/write confusion)
> replace WRITE with BLK_RW_ASYNC.
> Unfortunately, concurrent mm development made the unchanged place
> accidentally.

I see that was added after 2.6.31, and that is wrong. Your patch looks
good.

Acked-by: Jens Axboe <jens.axboe@...cle.com>

> 
> This patch fixes it too.
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> ---
>  mm/vmscan.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 4a7b0d5..e4a915b 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1088,7 +1088,7 @@ static unsigned long shrink_inactive_list(unsigned long max_scan,
>  	int lumpy_reclaim = 0;
>  
>  	while (unlikely(too_many_isolated(zone, file, sc))) {
> -		congestion_wait(WRITE, HZ/10);
> +		congestion_wait(BLK_RW_ASYNC, HZ/10);
>  
>  		/* We are about to die and free our memory. Return now. */
>  		if (fatal_signal_pending(current))
> -- 
> 1.6.0.GIT
> 
> 
> 

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/