linux-kernel - Re: [PATCH] xen: Disable stack protector for irq helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ACA2AFD.4080305@goop.org>
Date:	Mon, 05 Oct 2009 10:21:01 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Bastian Blank <bastian@...di.eu.org>,
	Ingo Molnar <mingo@...hat.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Stable Kernel <stable@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Xen-devel <xen-devel@...ts.xensource.com>
Subject: Re: [PATCH] xen: Disable stack protector for irq helper

On 10/04/09 18:35, Bastian Blank wrote:
> On Sun, Oct 04, 2009 at 04:06:13PM -0700, Jeremy Fitzhardinge wrote:
>   
>> On 10/04/09 11:30, Bastian Blank wrote:
>>     
>>> The stack protector needs additional registers on x86_32, which are not
>>> saved in calls to the small paravirt interrupt handlers. This leads to
>>> early crashes as registers are overwritten and not saved by the caller
>>> as instructed.
>>>       
>> Thanks for the patch, but I don't think its quite right.  
>> PV_CALLEE_SAVE_REGS_THUNK() is responsible for generating a wrapper for
>> the functions to save/restore all the appropriate registers.  If it is
>> failing to do so, then the correct fix is to update
>> PV_SAVE/RESTORE_ALL_CALLER_REGS.
>>     
> Well, I did not understand this part of the code, but you seem right. So
> lets try the following. I have not yet run tested it.
>
> Save all caller-saved registers on x86_32 for the paravirt callee saved
> registers.
>   

That looks better, but it is still overkill.  We only need to save the
set of registers the ABI requires the callee to preserve.  What
additional register(s) gets clobbered by stack-protector that need to be
saved?

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/