linux-kernel - Re: [bisected] 2.6.31 regression sis5513 PIO Mode 0 hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 4 Oct 2009 21:55:50 -0500
From:	David Fries <david@...es.net>
To:	Robert Hancock <hancockrwd@...il.com>
Cc:	linux-kernel@...r.kernel.org, d.stussy@...oo.com,
	Joao Ramos <joao.ramos@...v.pt>,
	Linus Torvalds <torvalds@...l.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Vojtech Pavlik <vojtech@...e.cz>
Subject: Re: [bisected] 2.6.31 regression sis5513 PIO Mode 0 hang

On Sat, Oct 03, 2009 at 06:57:42PM -0600, Robert Hancock wrote:
> On 10/02/2009 08:54 PM, David Fries wrote:
>> I just did a git bisection from 2.6.30 to 2.6.31 because 2.6.31 will
>> not boot on this system.  d.stussy@...oo.com's post September 12th
>> looks the same, different CPU but both have sis5513 IDE chips.  His
>> would normally init the ethernet chip next, mine would do PS/2 next,
>> both hang right after the Uniform CD-ROM message.
>>
>> This was bisected down to chaging PIO mode 0 for probing.  What
>> problem was that patch trying to solve?  Reverting just that patch at
>> the top of 2.6.31 tree works.  I can test patches.
>>
>> Assigned bugzilla.kernel.org bug 14310
>
> Well, it's the right thing to do (libata does it) but presumably doing  
> that in old IDE is triggering some kind of bug. Unless there's a  
> specific problem it was solving, or someone is interested in debugging  
> in detail (I'm certainly not interested in drivers/ide) it should likely  
> be reverted as we've done without it for so long..

First, if I'm going to do much debugging, how would I force the
ethernet device to come up first so I have netconsole?

How is the problem patch,
+       ide_port_for_each_dev(i, drive, hwif) {
+               if (port_ops && port_ops->set_pio_mode)
+                       port_ops->set_pio_mode(drive, 0);
+       }

Different from using hdparm to set the mode?  I do this,
hdparm -p 0 /dev/hda
hdparm -X pio0 /dev/hda
and the benchmarks give me about what I would expect 7MB/s instead of
the normal 40MB/s.

Then I can re-enable with,
hdparm -p 4 /dev/hda
hdparm -X udma5 /dev/hda
hdparm -d 1 /dev/hda
hda: UDMA/100 mode selected
and the drive is back up to speed, and obviously the kernel didn't
freeze.  Should there be anything different between what the patch
tried, and and hdparm's doing, other than kernel initiated and start
and a user program later on?

-- 
David Fries <david@...es.net>
http://fries.net/~david/ (PGP encryption key available)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/