linux-kernel - Re: [RFC][PATCH] perf tools: Merge trace.info content into perf.data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Oct 2009 08:22:04 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Mike Galbraith <efault@....de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH] perf tools: Merge trace.info content into
	perf.data


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> Hi,
> 
> Here is an attempt to remove the trace.info file. It works well for 
> me, the reason for it to be an RFC is that I have doubts about the 
> backward compatibility.
> 
> A file created by perf after his patch is unsupported by previous 
> version because the size of the headers have increased.

That's OK i think in terms of trace.info - trace.info was a temporary 
hack to begin with.

> That said, it's two new fields that have been added in the end of the 
> headers, and those could be ignored by previous versions if they just 
> handled the dynamic header size and then ignore the unknow part. The 
> offsets guarantee the compatibility.

Yes, that's how it should work.

> But previous versions handle the header size using its static size, 
> not dynamic, then it's not backward compatible.
> 
> Anyway, I'm not sure exactly how to handle that.

That's a bug in the previous version - mind doing a standalone fix for 
that so we can mark it Cc: stable?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/