linux-kernel - RE: [PATCH v3] mfd: ADP5520 Multifunction LCD Backlight and KeypadInput Device Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Oct 2009 09:50:43 +0100
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	"Mark Brown" <broonie@...nsource.wolfsonmicro.com>
CC:	"Mike Frysinger" <vapier@...too.org>,
	"Samuel Ortiz" <sameo@...ux.intel.com>,
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	<linux-kernel@...r.kernel.org>, "Bryan Wu" <cooloney@...nel.org>
Subject: RE: [PATCH v3] mfd: ADP5520 Multifunction LCD Backlight and KeypadInput Device Driver

>From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
>On Tue, Oct 06, 2009 at 04:05:45PM +0100, Hennerich, Michael wrote:
>> >From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
>
>> >According to the datasheet the GPIOs, light sensor and regulator can
>> >also generate interrupts?
>
>> Right - I know - but none of the subdevs are currently using this
>> functionality.
>
>You weren't very clear on the difference between the current state of
>the drivers and the capabilities of the chip there.

As you said there are chip internal interrupt sources for I/Os, keypad
presses and releases, ambient light sensor comparator states, and
overvoltage conditions.
The current state of the driver uses only interrupts for the keypad.
I think you agree that its common practice to only implement
functionality for chip features that are typically used.
There are exactly 8 GP signals which are muxed with Keypad and GPIO. In
case you use a 4x4 Keypad there is no GPIO left.
In case you use a 3x4 Keypad there is exactly 1 GPIO that can be exposed
to the gpiolib.

In one of your earlier posts you mentioned: "register an irq_chip for
the interrupt controller on it.  Support for doing this on I2C devices
was added at pretty much the same time as the IRQ_ONESHOT support."

Can you point me to what exactly was added to support this on I2C/SPI
devices? 

-Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/