linux-kernel - Re: linux-next: suspend tree build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Oct 2009 15:29:14 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: linux-next: suspend tree build failure

Hi Rafael,

On Wed, 7 Oct 2009 00:31:55 +0200 "Rafael J. Wysocki" <rjw@...k.pl> wrote:
>
> Thanks for the notification.
> 
> Did you cross-compile it by chance?  It builds for me on native x86_64 with
> allmodconfig, which is why I missed this issue.

I cross compile all my x86 builds as my big machines are all PowerPC.

> > I have used the version of the suspend tree from next-20091002 for today.
> 
> I added the #include <linux/compiler.h> to freezer.h, but obviously I couldn't
> verify if that fixed the problem.  Hopefully it did.

My guess was wrong.  You either need to leave the __cold off the
definition in kernel/freezer.c or move it before the function name.  No
other function definition in the kernel is marked __cold, but several
declarations are.

Also __cold only generates something for gcc >= 4.3 ...  I am using 4.4.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped