| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Oct 2009 21:08:08 -0300 From: Henrique de Moraes Holschuh <hmh@....eng.br> To: Randy Dunlap <randy.dunlap@...cle.com>, Ingo Molnar <mingo@...e.hu> Cc: Stephen Rothwell <sfr@...b.auug.org.au>, lenb@...nel.org, linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH -next] thinkpad_acpi: fix build, HOTKEY_POLL is optional On Fri, 09 Oct 2009, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@...cle.com> > > Fix optional part of driver to be built optionally: NAK! This happens because of (linux-next) commit 7f6443f7238a0aa9014b11a0a31ab76825d75cdf "thinkpad-acpi: Fix build on !CONFIG_THINKPAD_ACPI_HOTKEY_POLL" by Ingo. That commit is wrong, it must NOT be applied as explained in the thread starting at http://lkml.org/lkml/2009/9/27/30. Ingo, can you please check if you don't have that commit still in one of your trees that are fed into linux-next? It broke the driver now that the "backlight/thinkpad-acpi: issue backlight class events" patch landed in -next, just like I said it would happen... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists