linux-kernel - Re: checkpatch is not detecting bad whitespacing when using macros on formulas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Oct 2009 11:26:24 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Tilman Schmidt <tilman@...p.cc>
Cc:	Andy Whitcroft <apw@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andy Walls <awalls@...ix.net>
Subject: Re: checkpatch is not detecting bad whitespacing when using macros
 on formulas

Em Sun, 11 Oct 2009 13:01:26 +0200
Tilman Schmidt <tilman@...p.cc> escreveu:

> Mauro Carvalho Chehab schrieb:
> > While reviewing a patch from Andy Walls, I noticed that checkpatch v 0.29
> > didn't get any errors when bad whitespacing is used on some formulas:
> > 
> > $ checkpatch.pl cx23888-ir-part2_2.patch
> > total: 0 errors, 0 warnings, 1237 lines checked
> > 
> > cx23888-ir-part2_2.patch has no obvious style problems and is ready for submission.
> > 
> > However, there are several places at the patch like:
> > 
> > +static inline u16 ns_to_clock_divider(unsigned int ns)
> > +{
> > +       return count_to_clock_divider(
> > +                 DIV_ROUND_CLOSEST(CX23888_IR_REFCLK_FREQ/1000000 * ns, 1000));
> > +}
> 
> checkpatch is already complaining too much rather than too little.
> No need to add even more complaints.
> 
> The code you cite above is fine IMHO, but if you don't like it, feel
> free to raise your complaints. You can do so without help from
> checkpatch, too.

Chapter 3.1 of CodingStyle says:

	Use one space around (on each side of) most binary and ternary operators,
	such as any of these:

	        =  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=  ?  :

At the above, it should have an space before and after the first division
operator. So, we should or fix checkpatch.pl or remove the above rule from
CodingStyle.

Note that the patch has other similar troubles, like:

+       if (d > RXCLK_RCD+1)
+                                CX23888_IR_REFCLK_FREQ/1000000);
+       if (rem >= CX23888_IR_REFCLK_FREQ/1000000/2)
+       clocks = CX23888_IR_REFCLK_FREQ/1000000 * (u64) ns; /* millicycles    */
+       return DIV_ROUND_CLOSEST((n+1) * 100, 16);



Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/