linux-kernel - Re: [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: Remove the BKL from sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2009 20:44:22 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	John Kacur <jkacur@...hat.com>
CC:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Vincent Sanders <vince@...tec.co.uk>,
	Ingo Molnar <mingo@...e.hu>,
	Christoph Hellwig <hch@...radead.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jonathan Corbet <corbet@....net>,
	Mike Frysinger <vapier@...too.org>,
	David Howells <dhowells@...hat.com>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Roman Zippel <zippel@...ux-m68k.org>,
	Greg Ungerer <gerg@...inux.org>,
	Koichi Yasutake <yasutake.koichi@...panasonic.com>
Subject: Re: [PATCH 5/6 RFC] arch/m68knommu/kernel/process.c: Remove the BKL
 from sys_execve

Hi John,

On 10/13/2009 08:34 AM, John Kacur wrote:
>> From e36c53d296132bc0ddbf6d9fb43ea5ea56dbd4a2 Mon Sep 17 00:00:00 2001
> From: John Kacur<jkacur@...hat.com>
> Date: Mon, 12 Oct 2009 23:37:28 +0200
> Subject: [PATCH] arch/m68knommu/kernel/process.c: Remove the BKL from sys_execve
>
> This looks like a copy-and-paste of functionality that no-longer needs the bkl.
> Just remove it.
>
> Signed-off-by: John Kacur<jkacur@...hat.com>

Tested and runs fine on m68knommu.

Acked-by: Greg Ungerer <gerg@...inux.org>

Do you want me to push this into the m68knommu git tree,
for eventual merging into Linus' tree?  Or are you going
to push the whole set of patches together?

Regards
Greg



> ---
>   arch/m68knommu/kernel/process.c |    5 +----
>   1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
> index 8f8f4ab..5c9ecd4 100644
> --- a/arch/m68knommu/kernel/process.c
> +++ b/arch/m68knommu/kernel/process.c
> @@ -352,15 +352,12 @@ asmlinkage int sys_execve(char *name, char **argv, char **envp)
>   	char * filename;
>   	struct pt_regs *regs = (struct pt_regs *)&name;
>
> -	lock_kernel();
>   	filename = getname(name);
>   	error = PTR_ERR(filename);
>   	if (IS_ERR(filename))
> -		goto out;
> +		return error;
>   	error = do_execve(filename, argv, envp, regs);
>   	putname(filename);
> -out:
> -	unlock_kernel();
>   	return error;
>   }
>

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/