linux-kernel - Re: [GIT PULL] kbuild fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2009 23:10:19 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	Sam Ravnborg <sam@...nborg.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: [GIT PULL] kbuild fixes

On Mon, Oct 12, 2009 at 4:41 PM, Michael Tokarev <mjt@....msk.ru> wrote:
> Sam Ravnborg wrote:
>>
>> Hi Linus.
>>
>> A few kbuild related fixes.
>
> []
>>
>> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users
>
> As has been discussed previously (and Sam has been CC'ed), the fix
> is still incorrect.  It replaces "echo -ne" with "/bin/echo -ne",
> but neither of the two are guaranteed to support the necessary
> arguments and necessary (hexadecimal) escape sequences.  What should
> be used here is printf(1).  The trivial patch below (on top of these
> kbuild changes) fixes this issue.
>
> Thanks.
>
> /mjt
>
> Signed-Off-By: Michael Tokarev <mjt@....msk.ru>
>

Sorry, I just saw this email.

Hmm, printf(1) should be more portable than echo(1), I checked your patch,
how about using 'printf "%b" ' instead?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/