linux-kernel - Re: [patch 03/28] net: Remove BKL from tun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Oct 2009 01:19:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tglx@...utronix.de
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...e.hu, peterz@...radead.org, fweisbec@...il.com,
	vince@...tec.co.uk, jkacur@...hat.com, corbet@....net,
	hch@...radead.org, herbert@...dor.apana.org.au
Subject: Re: [patch 03/28] net: Remove BKL from tun

From: Thomas Gleixner <tglx@...utronix.de>
Date: Sat, 10 Oct 2009 15:35:33 -0000

> The lock_kernel/unlock_kernel() in cycle_kernel_lock() which is called
> in tun_chr_open() is not serializing against anything and safe to
> remove.
> 
> tun_chr_fasync() is serialized by get/put_tun() and fasync_helper()
> has no dependency on BKL. The modification of tun->flags is racy with
> and without the BKL so removing it does not make it worse.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/