linux-kernel - Re: [Bug #14388] keyboard under X with 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Oct 2009 14:02:10 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Boyan <btanastasov@...oo.co.uk>
cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Oleg Nesterov <oleg@...hat.com>,
	Paul Fulghum <paulkf@...rogate.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Ed Tomlinson <edt@....ca>, hirofumi@...l.parknet.co.jp
Subject: Re: [Bug #14388] keyboard under X with 2.6.31

On Wed, 14 Oct 2009, Boyan wrote:
> 
> Works for me. I couldn't reproduce the problem with only this patch on
> top of  2.6.31.4.

So just to verify: both the flush_to_ldisc() patch _and_ the 
"flush_delayed_work()" one fixed the problem for you? And you tested them 
independently? And you said you could reliably trigger it before?

Ok, that makes me happy, because it implies that this really is the root 
cause, with two different approaches to fixing the same problem both 
working independently of each other.

So if you confirm that I understand your test situation right, I will 
probably commit them both: I think the flush_to_ldisc() patch is a real 
locking improvement regardless of whether we then avoid calling it in a 
nested manner or not, and the flush_delayed_work() thing seems to be the 
right thing(tm) to do too.

Besides, even with the flush_delayed_work() thing, we're still faced with 
the theory of multiple keventd threads running the flush_to_ldisc on 
separate CPU's. Even though it's probably unlikely enough to never happen.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/