The ioctl is empty and needs no serialization. We might remove it completely but that would change the return value from -ENOIOCTLCMD to -ENOTTY. Signed-off-by: Thomas Gleixner Cc: Jeff Dike --- arch/um/drivers/mmapper_kern.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-2.6-tip/arch/um/drivers/mmapper_kern.c =================================================================== --- linux-2.6-tip.orig/arch/um/drivers/mmapper_kern.c +++ linux-2.6-tip/arch/um/drivers/mmapper_kern.c @@ -46,8 +46,8 @@ static ssize_t mmapper_write(struct file return count; } -static int mmapper_ioctl(struct inode *inode, struct file *file, - unsigned int cmd, unsigned long arg) +static long mmapper_ioctl(struct file *file, unsigned int cmd, + unsigned long arg) { return -ENOIOCTLCMD; } @@ -91,7 +91,7 @@ static const struct file_operations mmap .owner = THIS_MODULE, .read = mmapper_read, .write = mmapper_write, - .ioctl = mmapper_ioctl, + .unlocked_ioctl = mmapper_ioctl, .mmap = mmapper_mmap, .open = mmapper_open, .release = mmapper_release, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/