lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 14 Oct 2009 18:48:49 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Tim Hoppen <timhoppen@...il.com>
Cc:	lenb@...nel.org, rui.zhang@...el.com, jgarzik@...hat.com,
	tj@...nel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Added an additional Sony laptop to
 acpi_osi_dmi_table

On Wed, 2009-10-14 at 17:59 -0700, Tim Hoppen wrote:
> Signed-off-by: Tim Hoppen <timhoppen@...il.com>
> ---
>  drivers/acpi/blacklist.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index e56b2a7..01cca5f 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -211,6 +211,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  		     DMI_MATCH(DMI_PRODUCT_NAME, "Sony VGN-SR290J"),
>  		},
>  	},
> +	{
> +        .callback = dmi_disable_osi_vista,
> +        .ident = "Sony VGN-FW351J",
> +        .matches = {
> +                     DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
> +                     DMI_MATCH(DMI_PRODUCT_NAME, "VGN-FW351J"),
> +                },
> +        },

It looks like your not indenting correctly. The above lines should be
tabbed instead of just spaced over .. You may have done copy and paste
on this block from the code around this. Copy and paste usually doesn't
properly copy the tabs .. Could you resubmit this with the tabbing added
back in?

Daniel 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ