linux-kernel - Re: [PATCH] scripts/get_maintainer.pl: add role output option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Oct 2009 21:42:27 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/get_maintainer.pl: add role output option

On Thu, 2009-10-15 at 04:51 +0100, Ben Hutchings wrote:
> Add the output option '--roles' to get_maintainer.pl.  This causes it
> to show the role of each email address, i.e. why it was selected.

Hi Ben.

Interesting idea.

This patch applies with offsets against the latest version
that Andrew Morton has in his tree.

Here are the patches I posted a few days ago:
http://lkml.org/lkml/2009/10/10/11

Are the email addresses generated going
to be acceptable to all mailers or is --roles
just used for visual inspection?

Have you tested it with
git-send-email --cc-cmd "scripts/get_maintainer.pl --roles" ?

Trivial comment:

> + push_email_address($line, 'signed-off');
[] 
> + push_email_address($line, 'blamed');

The "signed-off" role though isn't necessarily
an actual "Signed-off-by:".  It could be an
"Acked-by:", or "tested-by:", or "reviewed-By:".

And the "blamed" keyword may be unnecessarily negative.

Maybe it could be "git-signer" and "modified-author"

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/