linux-kernel - Re: [PATCH] clockevents.c: fix symbol was not declared noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Oct 2009 14:25:25 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	john stultz <johnstul@...ibm.com>
Subject: Re: [PATCH] clockevents.c: fix symbol was not declared noise

On Sat, Oct 17, 2009 at 6:19 AM, H Hartley Sweeten
<hartleys@...ionengravers.com> wrote:
> Include "tick-internal.h" in order to pick up the extern function
> prototype for clockevents_shutdown().  This quiets the following
> spares build noise:
>
>  warning: symbol 'clockevents_shutdown' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
>

Looks good.
Reviewed-by: Yong Zhang <yong.zhang0@...il.com>

Cc'ed some experts.

> ---
>
> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
> index 620b58a..c30ba1f 100644
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -20,6 +20,8 @@
>  #include <linux/sysdev.h>
>  #include <linux/tick.h>
>
> +#include "tick-internal.h"
> +
>  /* The registered clock event devices */
>  static LIST_HEAD(clockevent_devices);
>  static LIST_HEAD(clockevents_released);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/