linux-kernel - Re: Leaks in trace reported by kmemleak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2009 14:20:22 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Zdenek Kabelac <zdenek.kabelac@...il.com>
Cc:	Li Zefan <lizf@...fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: Leaks in trace reported by kmemleak

On Mon, 2009-10-19 at 13:00 +0100, Catalin Marinas wrote:
> On Mon, 2009-10-19 at 11:15 +0200, Zdenek Kabelac wrote:
> > What is however interesting is the false positive leak for
> > dma_debug_init(). Which is sometimes listed and sometimes not - the
> > memory is allocated just once in the code during boot, so it's strange
> > that pointers to that area are sometimes out of kmemleak scan.
> 
> A workaround I had in the past was to not report an object unless it was
> found as a leak in two consecutive scans. I should probably reinstate
> this feature (could be optimised to use a second prio_tree containing
> only objects found as leaks).

OK, I re-added a form of this to the kmemleak.git tree and simplified
the scanning logic (meant initially to reduce the false positives). Now,
for an object to be reported, it needs to be found as leak during two
consecutive scans (this works around pointer moving from a structure to
a different one which was already scanned).

If you have time, could you please give it a try and see whether you
still get transient false positives?

As for the patch showing where an object is referred from, I think it's
still useful for debugging possible false negatives, so I'll leave it
in.

Thanks.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/