linux-kernel - Re: [PATCH] AF_UNIX: Fix deadlock on connecting to shutdown socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Oct 2009 23:18:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tomoki.sekiyama.qu@...achi.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	alan@...rguk.ukuu.org.uk, satoshi.oshima.fk@...achi.com,
	hidehiro.kawai.ez@...achi.com, hideo.aoki.tk@...achi.com
Subject: Re: [PATCH] AF_UNIX: Fix deadlock on connecting to shutdown socket

From: Tomoki Sekiyama <tomoki.sekiyama.qu@...achi.com>
Date: Mon, 19 Oct 2009 15:02:52 +0900

> I found a deadlock bug in UNIX domain socket, which makes able to DoS
> attack against the local machine by non-root users.
 ...
> Why this happens:
>  Error checks between unix_socket_connect() and unix_wait_for_peer() are
>  inconsistent. The former calls the latter to wait until the backlog is
>  processed. Despite the latter returns without doing anything when the
>  socket is shutdown, the former doesn't check the shutdown state and
>  just retries calling the latter forever.
> 
> Patch:
>  The patch below adds shutdown check into unix_socket_connect(), so
>  connect(2) to the shutdown socket will return -ECONREFUSED.
> 
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama.qu@...achi.com>
> Signed-off-by: Masanori Yoshida <masanori.yoshida.tv@...achi.com>

Looks good, applied, thank you!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/