lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Oct 2009 17:29:11 +0900 From: Trond Myklebust <trond.myklebust@....uio.no> To: Ingo Molnar <mingo@...e.hu> Cc: Yinghai Lu <yhlu.kernel@...il.com>, Pekka Enberg <penberg@...helsinki.fi>, Arjan van de Ven <arjan@...radead.org>, David Miller <davem@...emloft.net>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: nfs mount fail On Mon, 2009-10-19 at 10:23 +0200, Ingo Molnar wrote: > * Ingo Molnar <mingo@...e.hu> wrote: > > > > > * Trond Myklebust <trond.myklebust@....uio.no> wrote: > > > > > > --- a/fs/nfs/super.c > > > > +++ b/fs/nfs/super.c > > > > @@ -1253,6 +1253,7 @@ static int nfs_parse_mount_options(char *raw, > > > > default: > > > > dfprintk(MOUNT, "NFS: unrecognized " > > > > "transport protocol\n"); > > > > + kfree(string); > > > > return 0; > > > > } > > > > break; > > > > > > There is a possible clean up there too. We can move the other kfree() > > > calls out of the inner switch statement, and coalesce them all into a > > > single call. > > > > Correct - separately from the leak fix. (which potentially wants to go > > to -stable as well) > > Not necessarily -stable material though - this is a really light memory > leak and only on a rare failure path, i doubt anyone noticed in > practice. > > So d508afb fixed all that needed fixing and there's nothing serious > pending here. I've reverted all pending bits in tip:out-of-tree, so it's > pure -git now. I rarely have to carry any NFS fixes in out-of-tree, this > was an odd-one-out exception that fell through the cracks. > > Ingo OK. Could you resend the remaining leak fix, with the fixed up changelog and attributions so I can pass it on to Linus? Trond -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists