linux-kernel - Re: [PATCH 5/7] acpi: fix a bunch of style issues on 'actypes.h'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Oct 2009 08:53:19 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Felipe Contreras <felipe.contreras@...il.com>,
	linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>,
	Bob Moore <robert.moore@...el.com>,
	Lin Ming <ming.m.lin@...el.com>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 5/7] acpi: fix a bunch of style issues on 'actypes.h'

On Mon, 2009-10-19 at 17:03 +0200, Jiri Kosina wrote:
> On Mon, 19 Oct 2009, Felipe Contreras wrote:
> 
> > > I have never been in favor of merging whitespace-only patches (in a 
> > > sense that the sole purpose of them being to change whitespaces, but 
> > > no else value added).
> > If somebody tries to send a patch for that file that doesn't fix the
> > white-space, checkpatch will complain, and people will complain that
> > checkpatch complains, which is precisely what happened, 
> 
> Oh, well ... checkpatch warning about this is somewhat controversial. My 
> preferred way would be that it warns about whitespace only if there are 
> also some other (non-whitespace) changes.
> 
> > and I was requested to write this patch by Daniel Walker (final mail 
> > wasn't on the ml):
> > 
> > http://lkml.org/lkml/2009/9/14/183
> 
> This is something slightly different -- he asks you to fixup whitespace 
> issue in the code you are newly introducing, right?
> 
> > > And after today's discussion on kernel summit on this topic, I wouldn't
> > > expect any maintainer to merge it, sorry :)
> > What are you talking about?
> 
> Seems like many kernel maintainers are just tired of 
> 'whitespace-cleanup-only' patches that bring no real added value 
> otherwise.

May be some are tired, but others just say thanks and apply them,
because it is easier to apply than complain, and because they do not
mind if their subsystem becomes a tiny bit cleaner. Sometimes it may
cause troubles, but hey, development is not easy and we are accustomed
to fix conflict and amend patches. But the include/acpi/actypes.h does
not seem to be changing very often anyway.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/