| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Nov 2009 12:02:01 +0100 From: Peter Feuerer <pfe@...e.net> To: Borislav Petkov <petkovbb@...glemail.com> Cc: Borislav Petkov <petkovbb@...il.com>, linux-kernel@...r.kernel.org, Andreas Mohr <andi@...as.de> Subject: Re: [Patch] acerhdf: Return temperature in milidegree Hi Boris, Borislav Petkov writes: > On Mon, Oct 19, 2009 at 11:11:07PM +0200, Peter Feuerer wrote: >> I just had a look at the documentation concerning this topic: >> >> Documentation/thermal/sysfs-api.txt:162 >> >> temp Current temperature as reported by thermal zone (sensor) >> Unit: millidegree Celsius >> RO >> Required >> >> >> It is expected to be in millidegree, so I think we should discuss, >> modify and apply the patch. > > Well well, looka here, it is an interface! I guess the temperature has > to be in millidegrees for better granularity or similar. Now userspace > has to do temp / 1000.0 and so on. This is what the userspace applications like thermal-plugin of xfce-panel do. > > In that case, the patch should be applied. I'll give it a run later. Did you already give it a try? > > Minor nitpick: Add the sysfs-api requirement to the commit message > instead of "userspace applications." will change this, when submitting the patch to Andrew. kind regards, --peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists