linux-kernel - Re: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Nov 2009 19:19:53 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	André Goddard Rosa <andre.goddard@...il.com>
Cc:	laijs@...fujitsu.com, mingo@...e.hu, davem@...emloft.net,
	akpm@...ux-foundation.org, harvey.harrison@...il.com,
	linux list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra
	check

On Mon, Nov 02, 2009 at 03:26:36PM -0200, André Goddard Rosa wrote:
> From fd3098fe2764b049e23ea125a20979410699d257 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Andr=C3=A9=20Goddard=20Rosa?= <andre.goddard@...il.com>
> Date: Sun, 1 Nov 2009 13:46:26 -0200
> Subject: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
>    text    data     bss     dec     hex filename
>   15735       0       8   15743    3d7f lib/vsprintf.o-before
>   15719       0       8   15727    3d6f lib/vsprintf.o-minus-double-check
> 
> Signed-off-by: André Goddard Rosa <andre.goddard@...il.com>



Please add a changelog in your patches, I mean something that
explain your practical change.

I'm not sure this change is necessary, the only impact is a small
reduce of binary code. Well, why not.


> ---
>  lib/vsprintf.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 14e4197..af79152 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -747,8 +747,9 @@ static char *ip6_compressed_string(char *p, const
> char *addr)
>  				p = pack_hex_byte(p, hi);
>  			else
>  				*p++ = hex_asc_lo(hi);
> +			p = pack_hex_byte(p, lo);
>  		}
> -		if (hi || lo > 0x0f)
> +		else if (lo > 0x0f)
>  			p = pack_hex_byte(p, lo);
>  		else
>  			*p++ = hex_asc_lo(lo);
> -- 
> 1.6.5.2.140.g5f809

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/