linux-kernel - Re: [PATCH] qlogicpti: add missing parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 Nov 2009 16:19:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	James.Bottomley@...e.de
Cc:	roel.kluin@...il.com, linux-scsi@...r.kernel.org,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qlogicpti: add missing parentheses

From: James Bottomley <James.Bottomley@...e.de>
Date: Tue, 03 Nov 2009 17:51:49 -0600

> On Wed, 2009-11-04 at 00:38 +0100, Roel Kluin wrote:
>> `+' has a higher precedence than `?' so the condition always
>> evaluates to true and this is preprocessed to `7*((ql) - 1)'
>> 
>> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
>> ---
>>  drivers/scsi/qlogicpti.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> This one must be right, I think.
> 
> It looks plausible ... but it will increase the mailbox segment length
> by 4 ... someone needs to verify that this increase will actually work
> and won't run off the end of the mailbox table.

It should be fine, good find Roel.

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/