linux-kernel - Re: [PATCH v2 3/7] Adding general performance benchmarking subcommand to perf.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Nov 2009 19:41:08 +0900 (JST)
From:	Hitoshi Mitake <mitake@....info.waseda.ac.jp>
To:	mingo@...e.hu
Cc:	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au,
	tglx@...utronix.de, a.p.zijlstra@...llo.nl, efault@....de,
	acme@...hat.com, fweisbec@...il.com
Subject: Re: [PATCH v2 3/7] Adding general performance benchmarking
 subcommand to perf.

From: Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH v2 3/7] Adding general performance benchmarking subcommand to perf.
Date: Tue, 3 Nov 2009 18:29:26 +0100

> 
> * Hitoshi Mitake <mitake@....info.waseda.ac.jp> wrote:
> 
> > 
> > Adding general performance benchmarking subcommand to perf.
> > This patch adds bench/sched-pipe.c.
> > 
> > bench/sched-pipe.c is a benchmark program
> > to measure performance of pipe() system call.
> > This benchmark is based on pipe-test-1m.c by Ingo Molnar.
> > http://people.redhat.com/mingo/cfs-scheduler/tools/pipe-test-1m.c
> > 
> > Example of use:
> > % perf bench sched pipe               # Use default options
> > 4.575  	     	   		      # Result is time
> > % perf bench sched pipe -l 2000	      # This option means "loop 2000 counts"
> > 0.024
> 
> ok, -l makes sense.
> 
> Shouldnt we output the unit of measurement, i.e. '4.575 usecs'? Also, we 
> should perhaps print something like:
> 
>   % perf bench sched pipe
> 
>   (executing 1000000 pipe operations between two tasks)
> 
>      4.575 usecs per op
>     218579 ops/sec   
> 
> ?

I have to admit that single float value output is too simple.
So I'll fix the default output.

But, I believe that simple form makes sense for
processing by scripts or graph tools like gnuplot.
I'll add the option (may be --simple) to switch
friendliness of outputs.

Tools like automatic graph generator
will be helpful for us. I'll write it after
completion of current work.

I'll send new patch series including help improvement
you told in previous mail later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/