lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Nov 2009 16:37:55 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: phorton@...box.co.uk (Peter Horton) Cc: ecashin@...aid.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] prevent AoE causing cache aliases On Thu, 22 Oct 2009 15:22:28 +0100 phorton@...box.co.uk (Peter Horton) wrote: > To: ecashin@...aid.com Have you heard back from Ed on this? > Cc: linux-kernel@...r.kernel.org > Subject: [PATCH] prevent AoE causing cache aliases > Date: Thu, 22 Oct 2009 15:22:28 +0100 > Sender: linux-kernel-owner@...r.kernel.org > User-Agent: Mutt/1.5.9i > > This patch prevents the AoE block driver from creating cache aliases of > page cache pages on machines with virtually indexed caches. > > Building kernels on an AT91SAM9G20 board without this patch fails with > segmentation faults after a couple of passes. > > > Index: linux-2.6.31/drivers/block/aoe/aoecmd.c > =================================================================== > --- linux-2.6.31.orig/drivers/block/aoe/aoecmd.c 2009-09-09 23:13:59.000000000 +0100 > +++ linux-2.6.31/drivers/block/aoe/aoecmd.c 2009-10-22 10:24:50.000000000 +0100 > @@ -735,6 +735,21 @@ > part_stat_unlock(); > } > > +/* > + * Ensure we don't create aliases in VI caches > + */ > +static inline void > +killalias(struct bio *bio) > +{ > + struct bio_vec *bv; > + int i; > + > + if (bio_data_dir(bio) == READ) > + __bio_for_each_segment(bv, bio, i, 0) { > + flush_dcache_page(bv->bv_page); > + } > +} > + > void > aoecmd_ata_rsp(struct sk_buff *skb) > { > @@ -853,8 +868,12 @@ > > if (buf && --buf->nframesout == 0 && buf->resid == 0) { > diskstats(d->gd, buf->bio, jiffies - buf->stime, buf->sector); > - n = (buf->flags & BUFFL_FAIL) ? -EIO : 0; > - bio_endio(buf->bio, n); > + if (buf->flags & BUFFL_FAIL) > + bio_endio(buf->bio, -EIO); > + else { > + killalias(buf->bio); > + bio_endio(buf->bio, 0); > + } > mempool_free(buf, d->bufpool); > } Looks OK. This bugfix will cause a pointless __bio_for_each_segment() busywait loop to be executed on architectures for which flush_dcache_page() is a no-op. We don't have infrastructure to fix that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists