linux-kernel - Re: Fwd: [PATCH] arch/powerpc: Improve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Nov 2009 19:12:21 +0100
From:	Albrecht Dreß <albrecht.dress@...or.de>
To:	Chris Friesen <cfriesen@...tel.com>,
	Grant Likely <grant.likely@...retlab.ca>
Cc:	Linux kernel <linux-kernel@...r.kernel.org>,
	linuxppc-dev list <linuxppc-dev@...abs.org>,
	Dirk Eibach <eibach@...ys.de>
Subject: Re: Fwd: [PATCH] arch/powerpc: Improve _memcpy

See <http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-May/072582.html>.   
Any chance to get this one into the tree?  Grant?

Cheers, Albrecht.

Am 03.11.09 20:30 schrieb(en) Chris Friesen:
> 
> Forwarding to the ppc mailing list.
> 
> Chris
> 
> 
> -------- Original Message --------
> Subject: [PATCH] arch/powerpc: Improve _memcpy
> Date: Tue,  3 Nov 2009 15:20:56 +0100
> From: Dirk Eibach <eibach@...ys.de>
> To: linux-kernel@...r.kernel.org
> CC: Dirk Eibach <eibach@...ys.de>
> 
> The implementation of _memcpy_fromio and _memcpy_toio seems to be
> suboptimal for size 4.
> 
> Signed-off-by: Dirk Eibach <eibach@...ys.de>
> ---
>  arch/powerpc/kernel/io.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/io.c b/arch/powerpc/kernel/io.c
> index 1882bf4..8dc7547 100644
> --- a/arch/powerpc/kernel/io.c
> +++ b/arch/powerpc/kernel/io.c
> @@ -161,7 +161,7 @@ void _memcpy_fromio(void *dest, const volatile void
> __iomem *src,
>  		dest++;
>  		n--;
>  	}
> -	while(n > 4) {
> +	while(n >= 4) {
>  		*((u32 *)dest) = *((volatile u32 *)vsrc);
>  		eieio();
>  		vsrc += 4;
> @@ -190,7 +190,7 @@ void _memcpy_toio(volatile void __iomem *dest, const
> void *src, unsigned long n)
>  		vdest++;
>  		n--;
>  	}
> -	while(n > 4) {
> +	while(n >= 4) {
>  		*((volatile u32 *)vdest) = *((volatile u32 *)src);
>  		src += 4;
>  		vdest += 4;
> --
> 1.5.6.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...ts.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
> 
> 


Content of type "application/pgp-signature" skipped