linux-kernel - Re: [PATCH v3] x86: under bios control, restore AP's APIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 Nov 2009 10:06:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yong Wang <yong.y.wang@...ux.intel.com>
Cc:	Borislav Petkov <borislav.petkov@....com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Arjan van de Ven <arjan@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] x86: under bios control, restore AP's APIC_LVTTHMR to
 the BSP value


* Yong Wang <yong.y.wang@...ux.intel.com> wrote:

> On Mon, Nov 09, 2009 at 08:59:57AM +0100, Ingo Molnar wrote:
> > 
> > That's true in Linus's tree but Boris Petkov fixed the MCE init 
> > functions naming mess in the x86 tree, in these commits:
> > 
> >  b33a636: x86, mce: Add a global MCE init helper
> >  5e09954: x86, mce: Fix up MCE naming nomenclature
> > 
> > Please base your patch on:
> > 
> >   http://people.redhat.com/mingo/tip.git/README
> > 
> > to have the latest MCE code. So if you stick that init function into 
> > mcheck_init() in -tip it should be called once per bootup only. (I have 
> > not checked the other boot dependencies, please do that.)
> 
> By the time mcheck_init() executes, intel_init_thermal() has finished 
> running on BSP. Any suggestions on how to resolve this issue?

it's an early_initcall() right now - if that's not early enough then 
please call it explicitly from setup.c like you did it with the thermal 
init function from your previous patch. (and remove the early_initcall() 
line)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/