lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Nov 2009 06:17:34 +0100 From: Ingo Molnar <mingo@...e.hu> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Joe Perches <joe@...ches.com>, Naohiro Ooiwa <nooiwa@...aclelinux.com>, Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>, roland@...hat.com, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>, oleg@...hat.com Subject: Re: [PATCH] kernel.h: Add printk_ratelimited and pr_<level>_rl * Andrew Morton <akpm@...ux-foundation.org> wrote: > On Fri, 30 Oct 2009 16:21:47 -0700 > Joe Perches <joe@...ches.com> wrote: > > > +#define pr_emerg_rl(fmt, ...) \ > > + printk_ratelimited(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_alert_rl(fmt, ...) \ > > + printk_ratelimited(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_crit_rl(fmt, ...) \ > > + printk_ratelimited(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_err_rl(fmt, ...) \ > > + printk_ratelimited(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_warning_rl(fmt, ...) \ > > + printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_notice_rl(fmt, ...) \ > > + printk_ratelimited(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__) > > +#define pr_info_rl(fmt, ...) \ > > + printk_ratelimited(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) > > Would prefer pr_emerg_ratelimited personally. It's longer, but one > doesn't ask "wtf does _rl" mean and it avoids having two identifiers > which refer to the same thing. Yeah. It will be rarely used so that it wont ever really be 'obvious at a glance', even to folks well versed in kernel source code details. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists