lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Nov 2009 19:56:55 -0800 (PST) From: David Miller <davem@...emloft.net> To: arnd@...db.de Cc: dwmw2@...radead.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, eric.dumazet@...il.com Subject: Re: [PATCH v3] net/atm: move all compat_ioctl handling to atm/ioctl.c From: Arnd Bergmann <arnd@...db.de> Date: Wed, 11 Nov 2009 14:45:22 +0100 > We have two implementations of the compat_ioctl handling for ATM, the > one that we have had for ages in fs/compat_ioctl.c and the one added to > net/atm/ioctl.c by David Woodhouse. Unfortunately, both versions are > incomplete, and in practice we use a very confusing combination of the > two. > > For ioctl numbers that have the same identifier on 32 and 64 bit systems, > we go directly through the compat_ioctl socket operation, for those that > differ, we do a conversion in fs/compat_ioctl.c. > > This patch moves both variants into the vcc_compat_ioctl() function, > while preserving the current behaviour. It also kills off the COMPATIBLE_IOCTL > definitions that we never use here. > Doing it this way is clearly not a good solution, but I hope it is a > step into the right direction, so that someone is able to clean up this > mess for real. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists