linux-kernel - Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to &proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Nov 2009 13:13:34 -0800
From:	Joe Perches <joe@...ches.com>
To:	Julia Lawall <julia@...u.dk>, Andy Whitcroft <apw@...onical.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Am??rico Wang <xiyou.wangcong@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] sysctl.c: Change a .proc_handler = proc_dointvec to
 &proc_dointvec,

On Sun, 2009-11-15 at 21:40 +0100, Julia Lawall wrote:
> On Sun, 15 Nov 2009, Joe Perches wrote:
> > On Sun, 2009-11-15 at 19:20 +0100, Julia Lawall wrote:
> > > Searching for things that are declared as functions (either a definition 
> > > or a prototype), and then referenced as &f gives over 2000 results in 
> > > almost 600 files.
> > Just curious, do you know how many are referenced
> > without the &?
> I got over 95000 (not checked in detail, though).

Thanks.

I think that ~25+:1 ratio makes a good case for an
eventual conversion of the remaining uses.

> > If what is desired is kernel wide consistent use, yes.
> > What I would like is file/subsystem consistent use.
> > 
> > Looking at sysctl.c and seeing that different use
> > stand out was odd.
> 
> It would be possible to count the number of occurrences in a given file, 
> and then change the ones that have the less popular format, or a format 
> that occurs less than some percentage of time.

Maybe it'd be useful to add a coccinelle/spatch
directory in scripts and add these scripts so
that files and subsystems can updated over time.

I can not find a directory of coccinelle input
scripts for linux at:
http://coccinelle.lip6.fr/download.php
Is there a list somewhere?

Perhaps add a checkpatch test as well though
that might be an interesting test to write in
perl.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/