linux-kernel - Re: [PATCH v2 02/10] LIS3LV02D: Correct memory leak in module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Nov 2009 16:49:33 +0100
From:	Éric Piel <eric.piel@...mplin-utc.net>
To:	Samu Onkalo <samu.p.onkalo@...ia.com>
Cc:	daniel@...aq.de, pavel@....cz, linux-kernel@...r.kernel.org,
	lm-sensors@...sensors.org
Subject: Re: [PATCH v2 02/10] LIS3LV02D: Correct memory leak in module unload

Op 10-11-09 13:41, Samu Onkalo schreef:
> polled input device itself was not free'd.
> 
> Signed-off-by: Samu Onkalo <samu.p.onkalo@...ia.com>
Acked-by: Éric Piel <eric.piel@...mplin-utc.net>
> ---
>  drivers/hwmon/lis3lv02d.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/lis3lv02d.c b/drivers/hwmon/lis3lv02d.c
> index 7f43a3b..dbd0b05 100644
> --- a/drivers/hwmon/lis3lv02d.c
> +++ b/drivers/hwmon/lis3lv02d.c
> @@ -333,6 +333,7 @@ void lis3lv02d_joystick_disable(void)
>  	if (lis3_dev.irq)
>  		misc_deregister(&lis3lv02d_misc_device);
>  	input_unregister_polled_device(lis3_dev.idev);
> +	input_free_polled_device(lis3_dev.idev);
>  	lis3_dev.idev = NULL;
>  }
>  EXPORT_SYMBOL_GPL(lis3lv02d_joystick_disable);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/