linux-kernel - Re: [PATCH 02/15] osst: Use noop_llseek() instead of default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Nov 2009 17:09:06 +0000
From:	Jamie Lokier <jamie@...reable.org>
To:	Jan Blunck <jblunck@...e.de>
Cc:	linux-fsdevel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux-Kernel Mailinglist <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>, jkacur@...hat.com,
	Arnd Bergmann <arnd@...db.de>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Willem Riede <osst@...de.org>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>
Subject: Re: [PATCH 02/15] osst: Use noop_llseek() instead of default_llseek()

Jan Blunck wrote:
> __os_scsi_tape_open() suggests that llseek() doesn't work:
> "We really want to do nonseekable_open(inode, filp); here, but some
>  versions of tar incorrectly call lseek on tapes and bail out if that
>  fails.  So we disallow pread() and pwrite(), but permit lseeks."
> 
> Instead of using the fallback default_llseek() the driver should use
> noop_llseek() which leaves the file->f_pos untouched but succeeds.

st.c has the same comment, but I didn't see a patch for st.c in the series.

-- Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/