linux-kernel - Re: [PATCH] Staging: IIO: Add tsl2560-2 support to tsl2563 driver + drop tsl2561, driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Nov 2009 22:14:37 +0200
From:	Amit Kucheria <amit.kucheria@...durent.com>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] Staging: IIO: Add tsl2560-2 support to tsl2563 driver + 
	drop tsl2561, driver.

On Fri, Nov 20, 2009 at 9:12 PM, Jonathan Cameron <jic23@....ac.uk> wrote:
> These parts (tsl2560-tsl2563) are identical in interface.
> The tsl2563 driver is more advanced so makes sense to drop
> the tsl2561 driver.
>
> Signed-off-by: Jonathan Cameron <jic23@....ac.uk>
> ---
> Greg, I've done the changes and driver removal as a single patch.
> Can separate into two if you would prefer?
>
> Amit, as promised I have tested against the tsl2561 on an imote2
> sensor board (for which the original driver was written). All seems
> to work as intended.  Only changes are addition of devices to the
> device table and Kconfig comment changes to reflect new support.
> Hope you don't mind, but I dropped the N900 reference.  These things
> are pretty common (including the new parts) and we don't really
> want to encourage people to start listing where they found. I
> haven't done any of the other changes I suggested, but can do
> those as a follow up patch if you don't mind?
>
> There are a few more similar chips with slightly different conversion
> functions.
>
> Thanks,
>
> Jonathan

Jonathan,

Changes looks good. I'll send my acks on the split up patches.

I'm working on moving this driver to the input subsystem as agreed. I
was planning to address your review comments in that rework. I can
defer that work if you want.

Regards,
Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/