linux-kernel - Re: drivers/dma/ipu/ipu_idmac.c: use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Nov 2009 19:20:34 +0100 (CET)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: drivers/dma/ipu/ipu_idmac.c: use resource_size()

On Mon, 23 Nov 2009, H Hartley Sweeten wrote:

> Use resource_size() for ioremap.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Guennadi Liakhovetski <g.liakhovetski@....de>

Acked-by: Guennadi Liakhovetski <g.liakhovetski@....de>

> 
> ---
> 
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 9a5bc1a..bfa2126 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1771,16 +1771,14 @@ static int __init ipu_probe(struct platform_device *pdev)
>  		ipu_data.irq_fn, ipu_data.irq_err, ipu_data.irq_base);
>  
>  	/* Remap IPU common registers */
> -	ipu_data.reg_ipu = ioremap(mem_ipu->start,
> -				   mem_ipu->end - mem_ipu->start + 1);
> +	ipu_data.reg_ipu = ioremap(mem_ipu->start, resource_size(mem_ipu));
>  	if (!ipu_data.reg_ipu) {
>  		ret = -ENOMEM;
>  		goto err_ioremap_ipu;
>  	}
>  
>  	/* Remap Image Converter and Image DMA Controller registers */
> -	ipu_data.reg_ic = ioremap(mem_ic->start,
> -				  mem_ic->end - mem_ic->start + 1);
> +	ipu_data.reg_ic = ioremap(mem_ic->start, resource_size(mem_ic));
>  	if (!ipu_data.reg_ic) {
>  		ret = -ENOMEM;
>  		goto err_ioremap_ic; 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/