linux-kernel - Re: drivers/ide/au1xxx-ide.c: use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Nov 2009 12:20:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hartleys@...ionengravers.com
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: drivers/ide/au1xxx-ide.c: use resource_size()

From: "H Hartley Sweeten" <hartleys@...ionengravers.com>
Date: Mon, 23 Nov 2009 15:01:02 -0500

> On Monday, November 23, 2009 11:38 AM, David Miller wrote:
>>>  
>>> -	ahwif->regbase = (u32)ioremap(res->start, res->end - res->start + 1);
>>> +	ahwif->regbase = (u32)ioremap(res->start, resource_size(res));
>>>  	if (ahwif->regbase == 0) {
>>>  		ret = -ENOMEM;
>>>  		goto out;
>>
>> That needs some fixing.  ioremap()'s return value is an
>> "__iomem" pointer, not an integer.  ->regbase's type should be
>> changed to something like "void __iomem *" etc.
> 
> FWIW, following is an updated patch that fixes the "__iomem" pointer.

Please, I've already applied your resource_size() patch, and you
should submit a seperate patch relative to that in order to address
the ioremap() pointer issues.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/