lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Nov 2009 14:22:43 +1100 From: Paul Mackerras <paulus@...ba.org> To: Nathan Fontenot <nfont@...tin.ibm.com> Cc: linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] CPU DLPAR handling Nathan Fontenot writes: > Register the pseries specific handlers for the powerpc architecture handlers > for the cpu probe and release files. This also implements the cpu DLPAR > addition and removal of CPUS from the system. ... > + /* configure-connector reports cpus as living in the base > + * directory of the device tree. CPUs actually live in the > + * cpus directory so we need to fixup the full_name. > + */ > + cpu_name = kzalloc(strlen(dn->full_name) + strlen("/cpus/") + 1, > + GFP_KERNEL); > + if (!cpu_name) { > + dlpar_free_cc_nodes(dn); > + return -ENOMEM; > + } > + > + sprintf(cpu_name, "/cpus/%s", dn->full_name); I would have expected dn->full_name to start with a '/' already, in which case this will end up with two consecutive slashes after 'cpus'. I think that will probably cause problems. Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists