linux-kernel - Re: linux-next: workqueues tree build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Nov 2009 07:49:56 -0500
From:	Andy Walls <awalls@...ix.net>
To:	Peter Ujfalusi <peter.ujfalusi@...ia.com>
Cc:	ext Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	ext Tejun Heo <tj@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Takashi Iwai <tiwai@...e.de>
Subject: Re: linux-next: workqueues tree build failure

On Thu, 2009-11-26 at 13:44 +0200, Peter Ujfalusi wrote:
> On Thursday 26 November 2009 12:18:59 ext Mark Brown wrote:
> > On Thu, Nov 26, 2009 at 11:31:15AM +0200, Peter Ujfalusi wrote:
> > > For a quick fix, I can convert the tlv320dac33 driver to use this, and
> > > revisit later, if it does not fulfill the timing requirements for the HW.
> > 
> > If there are problems then creating a dedicated thread you can wake
> > would probably do the job.
> 
> For now I'm going to change the create_rt_workqueue to 
> create_singlethread_workqueue, that is available at the wq.git of kernel.org.
> 
> If it is not sufficient, than I might use dedicated thread, which I woke up, but 
> I would like to keep that as a backup plan, since it needs more work ;)

Peter,

I would suspect using a single-threaded workqueue is better than a
wake_up() of another thread.  IIRC, after queuing work, the workqueue's
single thread may run almost immediately on the same processor.  With
waking up sleeping threads, I've run into scheduler delays around 10 ms
on a dual core x86_64 desktop system.

Regards,
Andy

> I'll send the patch in a few minutes.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/