linux-kernel - Re: [PATCH] b43legacy: Port b43 rfkill fix to b43legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 26 Nov 2009 10:19:46 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Stefan Bader <stefan.bader@...onical.com>
CC:	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH] b43legacy: Port b43 rfkill fix to b43legacy

On 11/26/2009 08:49 AM, Stefan Bader wrote:
> Resending this. I believe I messed up with the recipients the last time.
> 
> -Stefan
> 
>>>From d800aef9db80ba1168f336791f4c5e8d4d0517c3 Mon Sep 17 00:00:00 2001
> From: Stefan Bader <stefan.bader@...onical.com>
> Date: Thu, 19 Nov 2009 14:52:22 -0600
> Subject: [PATCH] b43legacy: Port b43 rfkill fix to b43legacy
> 
> BugLink: https://bugs.launchpad.net/bugs/476154
> 
> "b43: Fix Bugzilla #14181 and the bug from the previous 'fix'" fixed
> a crash with the b43 driver, that happens if the radio switch is
> turned off.
> The same happens when using the b43legacy driver and it was verified,
> that the same changes just work in that case too.
> 
> Signed-off-by: Stefan Bader <stefan.bader@...onical.com>
> ---
>  drivers/net/wireless/b43legacy/rfkill.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/b43legacy/rfkill.c b/drivers/net/wireless/b43legacy/rfkill.c
> index 8783022..ad7083e 100644
> --- a/drivers/net/wireless/b43legacy/rfkill.c
> +++ b/drivers/net/wireless/b43legacy/rfkill.c
> @@ -34,7 +34,8 @@ bool b43legacy_is_hw_radio_enabled(struct b43legacy_wldev *dev)
>  		      & B43legacy_MMIO_RADIO_HWENABLED_HI_MASK))
>  			return 1;
>  	} else {
> -		if (b43legacy_read16(dev, B43legacy_MMIO_RADIO_HWENABLED_LO)
> +		if (b43legacy_status(dev) >= B43legacy_STAT_STARTED &&
> +		    b43legacy_read16(dev, B43legacy_MMIO_RADIO_HWENABLED_LO)
>  		    & B43legacy_MMIO_RADIO_HWENABLED_LO_MASK)
>  			return 1;
>  	}

This issue is already addressed by the patch in
http://marc.info/?l=linux-wireless&m=125902335810157&w=2.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/