linux-kernel - Re: [patch 1/3] rtc-x1205: fix rtc_time to y2k register value conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Nov 2009 22:40:54 +0100
From:	Alessandro Zummo <a.zummo@...ertech.it>
To:	Johannes Weiner <jw@...ix.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Gortmaker <p_gortmaker@...oo.com>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/3] rtc-x1205: fix rtc_time to y2k register value
 conversion

On Thu, 26 Nov 2009 02:02:34 +0100
Johannes Weiner <jw@...ix.com> wrote:

> eah, I think so too, although I hope we can get feedback from the
> authors beforehand.
> 
> Because #1 looks obvious to me and makes the driver at all usable for
> me but the code has been like that since the initial merge in 2006.
> So either
> 
> 	a) nobody ever set the date with this thing,
> 	b) every embedded linux company has its own private patch or
> 	c) I am missing something,
> 
> where likelyhood is in reverse order.  That makes me feel slightly
> uncomfortable.

 The last time I used an x1205 it worked nicely. It's been two or three
 years since. However the datasheet says 0x19 o 0x20 so your patch
 looks good.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/