linux-kernel - [PATCH]: at91 slowclock: fix two bugs when disabling the PLLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 1 Dec 2009 08:22:48 +0100
From:	Julien Langer <julien.langer@...glemail.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH]: at91 slowclock: fix two bugs when disabling the PLLs

Hi,

attached are two patches which fix two problems with the at91 slowclock code:

the first one fixes a problem during suspend: When turning off the
PLLs, wait for the LOCKA/LOCKB flags to be unset instead of being set
(which will never happen).

The second patch fixes a problem of trying to turn on/off a PLL which
was already disabled: ohci-at91 disables PLLB when going to suspend.
The slowclock code however tries to do the same. In that case the
slowclock code just stores and restores a 0 to the PLLB register which
results in the wait_pllblock loop to hang until it reaches the
timeout. This patches fixes the problem by only restoring the
PLLA/PLLB registers when they were != 0.

PS: please CC me, I'm not on the list.

View attachment "at91_slowclock_pll_unlock.patch" of type "text/x-patch" (1985 bytes)

View attachment "at91_slowclock_pll_fix.patch" of type "text/x-patch" (1989 bytes)