linux-kernel - Re: [PATCH 21/24] cgroup: define empty css_put() when !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Dec 2009 23:52:43 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Paul Menage <menage@...gle.com>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Li Zefan <lizf@...fujitsu.com>, Nick Piggin <npiggin@...e.de>,
	linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 21/24] cgroup: define empty css_put() when !CONFIG_CGROUPS

On Wed, Dec 02, 2009 at 02:48:03PM -0800, Paul Menage wrote:
> On Tue, Dec 1, 2009 at 7:12 PM, Wu Fengguang <fengguang.wu@...el.com> wrote:
> > --- linux-mm.orig/include/linux/cgroup.h        2009-11-02 10:18:41.000000000 +0800
> > +++ linux-mm/include/linux/cgroup.h     2009-11-02 10:26:22.000000000 +0800
> > @@ -581,6 +581,9 @@ static inline int cgroupstats_build(stru
> >        return -EINVAL;
> >  }
> >
> > +struct cgroup_subsys_state;
> > +static inline void css_put(struct cgroup_subsys_state *css) {}
> > +
> >  #endif /* !CONFIG_CGROUPS */
> 
> This doesn't sound like the right thing to do - if !CONFIG_CGROUPS,
> then the code shouldn't be able to see a css structure to pass to this
> function.

I agree. The high level code should be ifdefed.
-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/