linux-kernel - Re: [PATCH] therm_adt746x: Don't access non-existing register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Dec 2009 13:40:54 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Michel Dänzer <michel@...nzer.net>,
	"Darrick J. Wong" <djwong@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Colin Leroy <colin@...ino.net>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH] therm_adt746x: Don't access non-existing register

On Wed, 2009-12-02 at 09:19 +0100, Jean Delvare wrote:
> Michel, Darrick,
> 
> Apparently you are using the therm_adt746x driver, so maybe you would
> be interested in testing and carrying the following patch. I've sent it
> to Colin Leroy, who is listed as the maintainer for this driver, 1.5
> month ago, but did not hear back.

I will take it.

Basic rule is: CC to linuxppc-dev@...ts.ozlabs.org ;-)

That way it gets picked up by patchwork and doesn't get lost. Even if it
goes low on my priority list it will not be lost and I'll eventually
pick it up.

Cheers,
Ben.

> * * * * *
> 
> The ADT746x don't have any register at sub-address 0, so better use an
> existing register for the initial test read.
> 
> Signed-off-by: Jean Delvare <khali@...ux-fr.org>
> Tested-by: Tim Shepard <shep@...m.mit.edu>
> Cc: Colin Leroy <colin@...ino.net>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> ---
>  drivers/macintosh/therm_adt746x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.32-rc4.orig/drivers/macintosh/therm_adt746x.c	2009-10-12 11:53:59.000000000 +0200
> +++ linux-2.6.32-rc4/drivers/macintosh/therm_adt746x.c	2009-10-14 17:27:46.000000000 +0200
> @@ -387,7 +387,7 @@ static int probe_thermostat(struct i2c_c
>  	i2c_set_clientdata(client, th);
>  	th->clt = client;
>  
> -	rc = read_reg(th, 0);
> +	rc = read_reg(th, CONFIG_REG);
>  	if (rc < 0) {
>  		dev_err(&client->dev, "Thermostat failed to read config!\n");
>  		kfree(th);
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/