linux-kernel - return value of platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2009 09:55:54 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Julia Lawall <julia@...u.dk>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org, David Vrabel <dvrabel@...om.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: return value of platform_get_irq

Hello Julia,

in commit 305b3228 the return value indicating failure in
platform_get_irq was changed.

I tried to create a semantic patch for that, but I have failed as spatch
always says something like:

	Fatal error: exception Failure("minus: parse error: ...

Actually what is needed is that (probably) all usages of:

	ret = platform_get_irq(dev, num);
	if (!ret) {
		...

and equivalent are converted to

	ret = platform_get_irq(dev, num);
	if (ret <= 0) {
		...

(Actually I think "ret < 0" would be more correct in most situations,
but as 0 was handled as error before it's more conservative to keep it
this way.)

I assume it's easy for you to come up with a patch.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/