linux-kernel - Re: usb_autopm_*() removal build failure...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2009 21:47:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	gregkh@...e.de
Cc:	stern@...land.harvard.edu, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: usb_autopm_*() removal build failure...

From: Greg KH <gregkh@...e.de>
Date: Fri, 11 Dec 2009 20:05:24 -0800

> Here's the patch, sent back in August:
> 	 http://marc.info/?l=linux-netdev&m=125071045301270&w=2
> 
> Can you take it from there, or do you need me to forward it on?

I tossed this into the net-2.6 tree, but...

I would recommend that in the future when you have the
dependency of an API change that's going to break the
build, you take in the necessary change.  And you make
sure such a commit is in your tree before the commit
that removes the API.

That posting had all the markings of something that wasn't
my business applying:

1) the subject said "usb" and nothing about networking or
   a specific networking driver

2) it was resolving an API issue introduced by another tree

This also means you weren't doing allmodconfig builds on your USB tree
this entire time, because if you had you would have realized that this
fix belonged there not in net-2.6 :-)  And if the USB bits were
going in via -next I'm really surprised Stephen Rothwell wasn't
complaining about this too :)

Anyways, next time, please resolve API issues internally when you
do things that will break the build otherwise.

We can merge it all together during the merge window just fine.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/